Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading raster tiles with temporal dimensions #211

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

goergen95
Copy link
Member

No description provided.

@goergen95 goergen95 linked an issue Nov 29, 2023 that may be closed by this pull request
@goergen95 goergen95 self-assigned this Nov 29, 2023
@goergen95 goergen95 added the bug Something isn't working label Nov 29, 2023
@goergen95
Copy link
Member Author

Hi, I this fixes the issue, I think. Would you mind to check? I also tried to make the code more understandable. Maybe let's have a discussion about the assumptions used here?

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (70157bb) 73.31% compared to head (4fd992c) 74.40%.
Report is 1 commits behind head on main.

Files Patch % Lines
R/calc_indicators.R 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   73.31%   74.40%   +1.09%     
==========================================
  Files          43       43              
  Lines        1825     1817       -8     
==========================================
+ Hits         1338     1352      +14     
+ Misses        487      465      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goergen95 goergen95 merged commit 6e14fcb into main Nov 29, 2023
10 checks passed
@goergen95 goergen95 deleted the 209-temporal-tile-mapping-issue branch November 29, 2023 12:31
@karpfen
Copy link
Collaborator

karpfen commented Nov 29, 2023

Sorry, I saw your request too late. I'm testing on my data right now that caused the problem in the first place.

@karpfen
Copy link
Collaborator

karpfen commented Nov 30, 2023

@goergen95 I think the original problem is solved, but it's still failing for me because the calc_landcover function returns zero-length tibbles instead of NAs. I'm currently going through my data to identify a reproducible example

@goergen95
Copy link
Member Author

But shouldn't that be covered for with 87b99ba?

@karpfen
Copy link
Collaborator

karpfen commented Nov 30, 2023

I don't have the original error anymore, because my session crashed. But I think I received the new error message from calc_indicators:

if (any(n_rows == 0)) {
stop(paste("0-length tibbles returned for some assets.\n",
"Make sure the indicator function returns NA if it cannot be calculated for an asset."))
}

This would mean that the landcover indicator returned a zero-length tibble. That's my guess at least. I'm still looking for the offending polygon.

@goergen95
Copy link
Member Author

Oh, I see what you mean now. So there is a bug in the landcover function that is not directly related to this PR.

@karpfen
Copy link
Collaborator

karpfen commented Nov 30, 2023

You're right, I'll add it as an issue, I managed to find a reprex now, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESA Landcover tile mapping issue
2 participants